feat(data-modeling): add remove collection to diagram drawer COMPASS-9658 #7186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the functionality to remove collections from data modeling diagrams via the sidebar drawer. It also includes a defensive fix to handle cases where the selected item in the diagram no longer exists, preventing errors and gracefully closing the drawer instead.
- Implements collection deletion feature in the diagram editor sidebar
- Adds defensive handling for non-existent selected items to prevent throwing errors
- Updates e2e tests to cover collection management operations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-e2e-tests/tests/data-modeling-tab.test.ts | Adds new test for collection management and updates existing test selectors |
| packages/compass-e2e-tests/helpers/selectors.ts | Updates selectors for collection name input and adds delete button selectors |
| packages/compass-data-modeling/src/store/diagram.ts | Implements deleteCollection action and RemoveCollection edit handling |
| packages/compass-data-modeling/src/services/data-model-storage.ts | Adds RemoveCollection schema validation |
| packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.tsx | Adds delete collection functionality and defensive handling for missing items |
| packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.spec.tsx | Adds unit test for collection deletion |
| packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx | Adds data-testid for the name input field |
Comments suppressed due to low confidence (1)
packages/compass-data-modeling/src/store/diagram.ts:272
- The RemoveRelationship case has been completely removed from updateSelectedItemsFromAppliedEdit, but this logic was likely needed to clear selection when a relationship is deleted. This could leave a dangling selection state.
case 'RenameCollection': {
Anemy
added
the
feature flagged
gribnoysup
reviewed
Aug 12, 2025
packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.spec.tsx
Outdated
Show resolved
Hide resolved
gribnoysup
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-9658
Also a drive by updating how we handle when there's a selection on the diagram that doesn't exist. Previously we would throw, now we have it close the drawer by having no selection. Discussion on that in https://mongodb.slack.com/archives/C08P2P6ADJL/p1754762241343459
remove.collection.mp4